DATAREDIS-728 - Fix unnecessary cache configurations map creation in RedisCacheManagerBuilder.withInitialCacheConfiguration #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kezhuw
changed the title
kezhuw
changed the title
|
Thanks a lot for your pull request. I'll take it from here. |
mp911de
pushed a commit
that referenced
this pull request
Nov 16, 2017
…acheManagerBuilder. We now reuse the initially created map and add or replace initial configurations in place instead of creating each time a new map. Original pull request: #293.
mp911de
added a commit
that referenced
this pull request
Nov 16, 2017
Add tests. Add author tag. Original pull request: #293.
mp911de
pushed a commit
that referenced
this pull request
Nov 16, 2017
…acheManagerBuilder. We now reuse the initially created map and add or replace initial configurations in place instead of creating each time a new map. Original pull request: #293.
mp911de
added a commit
that referenced
this pull request
Nov 16, 2017
Add tests. Add author tag. Original pull request: #293.
|
That's now merged, polished and backported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RedisCacheManagerBuilder.withInitialCacheConfiguration appends new cache configurations by doing:
initialCaches.While just Map.putAll can accomplish this.